Re: svn commit: r12027 - trunk

Julian Foad wrote:

> Branko Čibej wrote:
>
>> brane@mithril:~$ uname -rs
>> FreeBSD 5.0-RELEASE
>> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]\|0\.9\.[1-9][0-9]'
>> 0
>> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]'
>> 5
>
>
> Thanks. I don't know why that doesn't work as I expect it to and as
> it works on most systems, but I've reverted that part of the change in
> r12044.

I tried several variants, but not one with '\|' worked. I don't know
why, either.

> (We don't have an urgent need to support APR versions 0.9.(>= 10) but
> if and when anyone wants to revisit this version-checking code I
> suggest accepting just one regexp and allowing it to be an arbitrary
> regexp with grouping and alternation, say by using "echo $VERSION |
> grep ^$REGEXP" instead of testing two separate regexps with "expr
> $VERSION : $REGEXP" commands.)

We'll burn that bridge when we get to it. :-)

> Sorry for the breakage.

Hey, that's what the automatic tests are for, after all. :-)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 26 17:56:33 2004