Re: svn commit: r12012 - in trunk/subversion: libsvn_client libsvn_wc tests/clients/cmdline

kfogel@collab.net writes:

> Philip Martin <philip@codematters.co.uk> writes:
>> At present if an baton is passed to svn_wc_cleanup all the access
>> batons opened are returned (yes, the function suffers from incomplete
>> documentation in svn_wc.h). If svn_wc_cleanup didn't have to return
>> the batons then we could close them as we go and make better use of
>> the subpool. svn_wc_cleanup2 isn't really an answer, since we would
>> still have to provide svn_wc_cleanup.
>
> As far as I can tell, no caller of svn_wc_cleanup(), except possibly
> for svn_wc_cleanup() itself, is depending on all the access batons

Correct as far as Subversion is concerned, and svn_wc_cleanup doesn't
need them.

> opened being returned. So aren't we free to change this aspect of its
> behavior, especially since it wasn't strictly documented anyway?

I don't know, are we? It's not Subversion that will have problems but
other projects built on Subversion.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org