[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Adding community resources to links page

From: <kfogel_at_collab.net>
Date: 2004-11-24 20:31:37 CET

Michael Ching <michaelc@wush.net> writes:
> Let me know if the patch needs fixing,

Okay... :-)

> --- project_links.html (revision 11992)
> +++ project_links.html (working copy)
> @@ -49,6 +49,21 @@
> </ul>
>
> +<h3>Community driven resources</h3>
> + <ul>
> + <li><b>Subversionary - A Wiki (which uses
> + SubWiki) for the promotion
> + of the Subversion version control system and for collecting
> + information on how to configure and use Subversion.<br>
> + http://subversionary.org/
> + </li>
> + <li><b>SVNForum - A Subversion community help and discussion forum for
> + exchanging information and tips with other Subversion users.<br>
> + http://svnforum.org/
> + </li>
> + </ul>

You opened "<b>" tags but didn't close them with "</b>". You must not
have tested this patch by viewing it in a browser, or you would have
seen immediately that all text for the remainder of the file was now
in bold.

The "<br>" tags should be self-closing ("<br/>"), as they are
elsewhere in the file, although due to the loose grammar of HTML it
didn't cause any real problems.

I fixed these things and made a few other tweaks and applied in
r12022. Thanks for the patch!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 24 20:34:32 2004

This is an archived mail posted to the Subversion Dev mailing list.