[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12003 - in trunk/subversion: include libsvn_fs_base libsvn_fs_fs mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-11-24 18:57:37 CET

kfogel@collab.net writes:

> > -
> > - serr = svn_fs_copy (src->info->root.root, /* the root object of src rev*/
> > - src->info->repos_path, /* the relative path of src */
> > - dst->info->root.root, /* the root object of dst txn*/
> > - dst->info->repos_path, /* the relative path of dst */
> > - src->pool);

[...]

> > + serr = svn_fs_copy (src->info->root.root, /* root object of src rev*/
> > + src->info->repos_path, /* relative path of src */
> > + dst->info->root.root, /* root object of dst txn*/
> > + dst->info->repos_path, /* relative path of dst */
> > + src->pool);
> > + }

> This is the minorest of nits, but there seems to be an inconsistent
> space-before-paren style going on here. I don't know whether that was
> already true in this file, but in any case, it's inconsistent even
> within the block of added lines above.

Not when you realize that the inconsistent parts aren't actually
added, but indented lines. All the new code uses the
no-space-before-paren mod_dav_svn standard. I just failed to catch
the inconsistency in the existing code during my edit.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 24 19:04:52 2004

This is an archived mail posted to the Subversion Dev mailing list.