[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11909 - in trunk/subversion: include libsvn_client libsvn_ra_dav libsvn_ra_local libsvn_ra_svn libsvn_repos mod_dav_svn svnserve

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-11-23 01:03:28 CET

julianfoad@tigris.org writes:

> Author: julianfoad
> Date: Mon Nov 15 09:53:51 2004
> New Revision: 11909
>
> Modified:
> trunk/subversion/include/svn_client.h
> trunk/subversion/include/svn_ra.h
> trunk/subversion/include/svn_repos.h
> trunk/subversion/libsvn_client/log.c
> trunk/subversion/libsvn_ra_dav/log.c
> trunk/subversion/libsvn_ra_dav/ra_dav.h
> trunk/subversion/libsvn_ra_local/ra_plugin.c
> trunk/subversion/libsvn_ra_svn/client.c
> trunk/subversion/libsvn_repos/log.c
> trunk/subversion/mod_dav_svn/log.c
> trunk/subversion/svnserve/serve.c
> Log:
> Revert r11162 which changed the log "limit" parameter to "unsigned",
> because using "unsigned" in high-level C interfaces is not a good idea
> and we have no precedent for it.

We use apr_size_t in quite a few places, that is unsigned, so there is
some precedent. I don't really care whether limit is signed or
unsigned, but now that you have reverted r11162 my previous comments
apply.

> --- trunk/subversion/include/svn_client.h (original)
> +++ trunk/subversion/include/svn_client.h Mon Nov 15 09:53:51 2004
> @@ -769,7 +769,7 @@
> svn_client_log2 (const apr_array_header_t *targets,
> const svn_opt_revision_t *start,
> const svn_opt_revision_t *end,
> - unsigned int limit,
> + int limit,
> svn_boolean_t discover_changed_paths,
> svn_boolean_t strict_node_history,
> svn_log_message_receiver_t receiver,

The effect of a negative limit is not documented, "it's undefined"
would do.

> --- trunk/subversion/include/svn_ra.h (original)
> +++ trunk/subversion/include/svn_ra.h Mon Nov 15 09:53:51 2004
> @@ -826,7 +826,7 @@
> const apr_array_header_t *paths,
> svn_revnum_t start,
> svn_revnum_t end,
> - unsigned int limit,
> + int limit,
> svn_boolean_t discover_changed_paths,
> svn_boolean_t strict_node_history,
> svn_log_message_receiver_t receiver,
>

ditto.

> --- trunk/subversion/include/svn_repos.h (original)
> +++ trunk/subversion/include/svn_repos.h Mon Nov 15 09:53:51 2004
> @@ -728,7 +728,7 @@
> const apr_array_header_t *paths,
> svn_revnum_t start,
> svn_revnum_t end,
> - unsigned int limit,
> + int limit,
> svn_boolean_t discover_changed_paths,
> svn_boolean_t strict_node_history,
> svn_repos_authz_func_t authz_read_func,

ditto.

> --- trunk/subversion/libsvn_ra_svn/client.c (original)
> +++ trunk/subversion/libsvn_ra_svn/client.c Mon Nov 15 09:53:51 2004
> @@ -1006,7 +1006,7 @@
> /** @since New in 1.2. */
> static svn_error_t *ra_svn_log2(void *baton, const apr_array_header_t *paths,
> svn_revnum_t start, svn_revnum_t end,
> - unsigned int limit,
> + int limit,
> svn_boolean_t discover_changed_paths,
> svn_boolean_t strict_node_history,
> svn_log_message_receiver_t receiver,

../svn/subversion/libsvn_ra_svn/client.c:1077: warning: comparison between signed and unsigned
../svn/subversion/libsvn_ra_svn/client.c:1086: warning: comparison between signed and unsigned

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 23 01:04:41 2004

This is an archived mail posted to the Subversion Dev mailing list.