Re: svn commit: r11978 - in trunk/subversion: libsvn_subr tests/libsvn_subr

Greg Hudson wrote:

>On Sun, 2004-11-21 at 17:57, brane@tigris.org wrote:
>
>
>>+ if ((memcmp (str1, str2, len1)) == 0)
>>
>>
>
>What, are we trying to allay people's concerns that this might bind as
>memcmp ((str1, str2, len1) == 0)?
>
>There's such a thing as too many parentheses.
>
>
So there is.

>>+ return TRUE;
>>+ else
>>+ return FALSE;
>>
>>
>... and there's also a place for "return (boolean expr);"
>
>
Yup. But note that the original code was already doing this.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 22 07:46:38 2004