Re: [PATCH] Update location of design document in HACKING

On Thu, 2004-11-18 at 11:02, kfogel@collab.net wrote:
> VK Sameer <sameer@collab.net> writes:
>
> Couple of (minor) things to watch out for:

Thanks, I'm a little nitpicky myself, so this is useful.

> I think after you changed
> "/" to "->" in the first hunk, you must have used your editor's
> refill-paragraph function (or reflow, or whatever it's called).

Actually, I shell'd out to 'fmt -72' ...

> This
> had two interesting effects: it made the diff look bigger than it
> actually is,

I thought it was because the extra words exceeded the 72-char limit and
pushed some words onto the next line. Is it better to let the extra
words push the limit out to 80 chars?

> and it made there be one space after a sentence-ending
> period instead of two spaces. We actually try to use two spaces.
> I've never been clear on how exactly standard this is, although I know
> it didn't start with us. The benefits of using two spaces are
> slightly improved readability, and being able to use sentence-motion
> commands in editors.

OK, will do that next time. It looks like fmt already has an option.
>From 'fmt --help':
[...]
-u, --uniform-spacing one space between words, two after sentences
[...]

> Again, very minor, just pointing these things out for next time.

Thanks
Sameer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 18 07:09:32 2004