[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11783 - trunk/subversion/svnserve

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-09 16:50:02 CET

Branko Čibej wrote:
> Julian Foad wrote:
>
>>>> apr_socket_listen(sock, 7);
>>>> +
>>>> + /* svn_cmdline_init() sets up the locale, but when we serve clients, we
>>>> + always want the "C" locale. */
>>>> + if (!setlocale (LC_ALL, "C"))
>>>> + {
>>>> + fprintf(stderr, "Can't set locale back to the \"C\" locale\n");
>>
>> Can that call actually fail?
>
> Any call can fail.

If you mean to imply that, therefore, every call should be checked, then should
not the above-quoted "apr_socket_listen" and "fprintf" be checked too?

Can setlocale(LC_ALL, "C") realistically be anticipated to fail on systems that
svnserve can run on, and does failure have such consequences that it is worth
worrying about and checking for?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 9 16:50:41 2004

This is an archived mail posted to the Subversion Dev mailing list.