[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Fwd: bash completion for subversion]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-09 13:32:52 CET

Martin, thank you for offering your work to the project. I feel the need to
defend (below) some of the comments I made, but these comments were to help
other people understand the relative merits of the existing method and your new
method. I'm sorry if it seemed like too much criticism.

Martin Blais wrote:
> On Mon, 08 Nov 2004 22:44:43 +0000, Julian Foad <julianfoad@btopenworld.com> wrote:
>>This runs "svn" (or "svnadmin") every time you ask for a completion, which is slow.
>
> IMO not a problem for completion, completion can be "slow"--if the
> definition of slow is the few microseconds it takes for svn to display
> the help.

No, that's not the definition. It takes between about 0.15 and 0.35 seconds to
do a completion on my 500 MHz Pentium III Linux system. That's a very
noticeable delay.

>>This doesn't remove unambiguous abbreviations such as "up" from its list of
>>candidates, despite the comment that says it does. Thus if you ask for
>>completion of "up", it offers "up" and "update" whereas the more useful thing
>>is to just complete it as "update".
>
> indeed, you could add a cmd to filter out short abbrevs or something.
> just an idea.

It's not "just" an idea. I proposed this a year ago and we decided it was a
good idea and implemented it in the existing "bash_completion" script. One of
the comments in your script is presumably derived from that:

     # Possible expansions, without unambiguous abbreviations such as "up".

But it is wrong: the code does not do what the comment says.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 9 13:33:37 2004

This is an archived mail posted to the Subversion Dev mailing list.