[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11775 - in trunk/subversion: include libsvn_wc

From: <kfogel_at_collab.net>
Date: 2004-11-08 21:04:36 CET

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> Well, originalprops provides the properties on the deleted file. If you
> provide a diff for an add, you provide the properties (not exactly
> everywhere, since that's buggy, but anyway). Then it's inconsistent to not
> provide properties on a file being deleted, isn't it? I don't, however,
> provide a diff in the form of a array of svn_prop_t,
> since, because all properties are going away, it would just be a list of
> all property names with null values. It is different with add, since
> sometimes we provide diffs against the copy source.

Hmm, no, addition and deletion are not totally symmetrical, and it's
fine to not provide props on a deletion. Deletion doesn't pay
attention to content or props, so why would we need the props?

> Maybe my explanation above clears it up. Wrapping the other way around is
> no problem,, and that's what we need in this file. The new routines in the
> file call a callbacks2_t, the wrapper dispatches to, for example,
> file_added plus props_changed (or just one of them) in the callbacks_t
> struct.

Er, hmm, I'm still not quite clear on it, but it could just be me.
Any additional documentation you want to check in would be welcome, of
course :-).

> > > +static struct svn_wc_diff_callbacks2_t callbacks2_wrapper = {
> > > + file_changed,
> > > + file_added,
> > > + file_deleted,
> > > + dir_added,
> > > + dir_deleted,
> > > + dir_props_changed
> > > +};
> >
> > Documentation?
>
> And name change for consistency.

Saw the commit, thanks!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 8 23:00:31 2004

This is an archived mail posted to the Subversion Dev mailing list.