[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] A libsvn_wc properties optimisation

From: <kfogel_at_collab.net>
Date: 2004-11-08 15:45:33 CET

Philip Martin <philip@codematters.co.uk> writes:
> The last point is related to svn_wc_props_modified_p. At present that
> function uses 6 stat() calls to determine when a file with properties
> has no modifications. Under the new scheme a single stat() on the
> working props file will determine if there is a file, and if not then
> there are no property modifications.
>
> The empty properties file, one that just contains END, will still be
> used as a working properties file--it will indicate a file which has
> property modifications that delete all properties.
>
> While it may be possible to use the presence of a working properties
> file to infer that there are properties modifications, initially at
> least I propose to leave the full comparison code. I think this will
> make old working copies compatible with the new code. Increasing the
> working copy version and then using the presence of the working
> properties file as an positive indication that there are properties
> modifications may be a later optimisation. It may even be possible to
> replace prop-time in the entries file with a props-modified flag and
> avoid using stat() altogether.

+1, it's a great idea.

If convenient, it would be great if you could first post the patch to
subversion/libsvn_wc/README, since that will be the official
documentation of how things work. I think that file is up-to-date
with the current code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 8 17:41:12 2004

This is an archived mail posted to the Subversion Dev mailing list.