[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11762 - branches/locking/subversion/include

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-11-05 23:24:52 CET

On Fri, 5 Nov 2004 sussman@tigris.org wrote:

> Modified: branches/locking/subversion/include/svn_fs.h
> Url: http://svn.collab.net/viewcvs/svn/branches/locking/subversion/include/svn_fs.h?view=diff&rev=11762&p1=branches/locking/subversion/include/svn_fs.h&r1=11761&p2=branches/locking/subversion/include/svn_fs.h&r2=11762
> ==============================================================================
> --- branches/locking/subversion/include/svn_fs.h (original)
> +++ branches/locking/subversion/include/svn_fs.h Fri Nov 5 15:29:10 2004
> @@ -300,51 +271,63 @@
> -/** An opaque object representing a user. */
> -typedef struct svn_fs_user_t svn_fs_user_t;
> +/** At certain times, filesystem functions need access to temporary
> + user data. For example, which user is changing a file? If the
> + file is locked, has an appropriate lock-token been supplied?
>
INconsistent commenting style. Leading * missing.

> +/** Accessors for the access context: */
> +
> +/** Push a lock-token @a token into the context @a access. The
> + context remembers all tokens it receives, and makes them available
> + to fs functions. */

Same.

> +svn_error_t *svn_fs_access_set_lock_token (svn_fs_access_t *access,
> + const svn_lock_token_t *token);
>
>
And now for something real: please call this svn_fs_access_add_lock_token,
since it doesn't replace an old token, which "set" implies.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 5 23:15:15 2004

This is an archived mail posted to the Subversion Dev mailing list.