[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: saving time stamps of files with subversion 1.1.1

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-04 14:25:40 CET

Ph. Marek wrote:
> http://subversion.tigris.org/issues/show_bug.cgi?id=1256

> On an import/commit, if a file has the "svn:text-time"-property set (to _any_
> value), it gets the file's current mtime set in this property, as a
> svn-timestring (yyyy-mm-ddThh:mm:ss.uuuuuuZ).
> On update/checkout/export, if a file has this property set *and* the
> configuration "use-commit-times" is set, the file's specific property
> overrides the commit-date.

Certainly I think the ability to save and restore a file's mtime is useful.
I'm not sure if a normal file property is the right place to store the time -
it seems very odd to have a property that the user can modify but Subversion
will always overwrite any value that the user puts in it.

One question (I haven't tested this patch to try to find the answer): when you
modify the property during a commit, do you also modify the text-base version
of that property and the working version of it?

> Please give me comments - better patches etc. welcome.

Please write a log message, in the style described in the HACKING file.

I'm sorry I don't have time to review the code functionally at the moment, but
I am interested so I will try to do so soon.

For now, I will just say: please pay attention to the formatting of the source
code. Try to set up your editor to help you with this. If you use vi(m) or
emacs, use the configuration files available in tools/dev/svn-dev.{el,vim} in
the Subversion source tree. Don't use tab characters for indentation; don't
put a space after an open parenthesis or before a close parenthesis; put spaces
around operators, including "="; when a parenthesised expression is continued
onto the next line, continue it from the column just after the open parenthesis.

Thanks.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 4 14:26:02 2004

This is an archived mail posted to the Subversion Dev mailing list.