[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash when fetching status

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-11-03 20:46:57 CET

SteveKing <steveking@gmx.ch> writes:

> But an unversioned directory isn't always unversioned as I
> discovered.

Do you mean this bug report?

> With a nested layout (i.e. working copy folders from
> different repositories) folder appear as unversioned, but still are
> versioned. Maybe the crash happens because of this?

I've tried that, I cannot reproduce it.

>
>>>I think this should be instead:
>>> if (parent_status
>>> && (parent_status->entry)
>>> && (parent_status->text_status != svn_wc_status_unversioned)
>>> && (parent_status->text_status != svn_wc_status_deleted)
>>> && (parent_status->text_status != svn_wc_status_missing)
>>> && (parent_status->text_status != svn_wc_status_obstructed)
>>> && (parent_status->entry->kind == svn_node_dir)
>>> && (eb->descend || (! pb)))
>>> {
>> I guess that would stop the crash, but is it just hiding the
>> underlying, unknown, cause of the bug? Is parent_status getting set
>> incorrectly?
>
> Please let's not get into the discussion again wheter a bug needs to
> be fixed or not. I think you guys know my opinion about this: if
> there's obviously a bug in the code, fix it. Even if you don't know
> exactly what has to happen to trigger the bug - it's still a bug, and
> in this case a crash.

I'm not keen on fixes that don't have regression tests; I strongly
dislike "fixes" for things that cannot be explained. How do you know
that status produces the right output with your fix?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 3 20:47:26 2004

This is an archived mail posted to the Subversion Dev mailing list.