[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Improvements to "svn_opt_args_to_target_array" etc.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-03 19:27:08 CET

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>The doc string for "svn_opt_args_to_target_array" doesn't say that it
>>strips the "@rev" part from the first two paths if @a
>>extract_revisions is set.
>>
>>Also, that feature of it is really an ugly way of combining two
>>different functions into one; it should be split into two functions,
>>the main one (used by nearly everything) which does not handle
>>revisions, and a special one (only used by diff and merge) which
>>ensures that there are only two targets, and extracts their revisions.
>>
>>The doc string for "svn_opt_parse_path" doesn't say what it does if
>>there is more than one "@" sign. It lists examples of input, but not
>>of the corresponding output.
>
> I wasn't sure if you were proposing to make these improvements, but +1
> if so...

Heh! I deliberately didn't say. Depends whether I get around to it any time soon.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 3 19:27:40 2004

This is an archived mail posted to the Subversion Dev mailing list.