[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix for ?\nnn in outputs from 'svn ls -v'

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2004-11-03 10:53:42 CET

Hi,

'svn ls -v' displayed '?\nnn's for the last changed date.

  nori1[16:06]% svn ls -v ~/svnwc/mantle
        1 nori1 572 10?\183?\238 24 18:28 GUIDELINES
        6 nori1 10?\183?\238 30 07:10 calculation/
        7 nori1 11?\183?\238 01 21:51 notes/
        4 nori1 10?\183?\238 28 22:07 publication/

Since I had learned this regression was due to double translation thanks
to r11172, I created and present a patch (only an one-line change).
Prease check it.

Thanks in advance,

-- 
|:  Noritada KOBAYASHI
|:  Dept. of General Systems Studies,
|:  Graduate School of Arts and Sciences, Univ. of Tokyo
|:  E-mail: nori1@dolphin.c.u-tokyo.ac.jp (preferable)
|:          nori@esa.c.u-tokyo.ac.jp
Log:
Fix a bug in 'svn ls -v' where the string for last changed date was
converted from UTF-8 to the current locale's encoding although it
was not a UTF-8 string but a native one, corrupting non-ASCII characters.
* subversion/clients/cmdline/ls-cmd.c (print_dirents): Use utf8_timestr
  instead of timestr as a last changed date argument of svn_cmdline_printf.
  utf8_timestr was prepared in r9795 but not used.
Index: subversion/clients/cmdline/ls-cmd.c
===================================================================
--- subversion/clients/cmdline/ls-cmd.c	(revision 11727)
+++ subversion/clients/cmdline/ls-cmd.c	(working copy)
@@ -98,7 +98,7 @@
                     dirent->created_rev,
                     dirent->last_author ? dirent->last_author : " ? ",
                     (dirent->kind == svn_node_file) ? sizestr : "",
-                    timestr,
+                    utf8_timestr,
                     utf8_entryname,
                     (dirent->kind == svn_node_dir) ? "/" : ""));
         }
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 3 10:54:09 2004

This is an archived mail posted to the Subversion Dev mailing list.