[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r11556 causes enormous fsfs memory use

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-11-02 21:41:02 CET

On Tue, 2 Nov 2004, Julian Foad wrote:

> Branko ─îibej wrote:
> > Peter N. Lundblad wrote:
> >> It apperas that apr_hash_set() allocates memory for each call that isn't a
> >> delete, even if there is an entry in the table already.
> >>
> > Then that's an APR bug. Sure, we should work around it in SVN, but it
> > needs fixing in APR, too.
>
> Is this still thought to be a bug in APR?
>
Actually, when I read the code mroe carefully, it allocates a new entry
when inserting a new entry. This isn't a bug. Our use in this case was to
insert, remove, insert, remove etc. This caused the leak. I think it would
be too much to require APR to cache deleted entries.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 2 21:32:52 2004

This is an archived mail posted to the Subversion Dev mailing list.