[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

repos_commit_editor and change_dir_prop

From: Chia-liang Kao <clkao_at_clkao.org>
Date: 2004-11-02 04:20:50 CET

According to svn_delta.h:

/*
 * 4. A producer must call @c change_dir_prop on a directory either
 * before opening any of the directory's subdirs or after closing
 * them, but not in the middle.
 */

but in commit.c: (change_dir_prop):

      SVN_ERR (svn_fs_node_created_rev (&created_rev,
                                        eb->txn_root, db->path, pool));

      if (db->base_rev < created_rev)
        return out_of_date (db->path, eb->txn_name);

If the directory is modified in this transaction, such as a file
within it is modified, the node_created_rev check here would find the
directory up-to-date and hence allow the change_dir_prop which should
cause out_of_date.

I wonder if there is any use of change_dir_prop before close_directory
(besides svk)?

Cheers,
CLK

  • application/pgp-signature attachment: stored
Received on Tue Nov 2 04:21:50 2004

This is an archived mail posted to the Subversion Dev mailing list.