[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix possible overflow with very large files in libsvn_delta

From: Norbert Unterberg <Norbert_at_Unterberg.de>
Date: 2004-11-01 15:14:51 CET


This is my first contribution so please react friendly on my possible
ignorance to your contribution rules :-)

When building TortoiseSVN, I noticed some compiler warnings when building
some of the SVN libraries. I looked closer at them and found a possible
problem in libsvn_delta. There is some piece of code that stores stream
offsets in a apr_size_t variable. This might fail on systems that support
very large files (64 bit file offsets stored in a 32 bit integer). The fix
was easy and I just replaced apr_size_t with svn_file_size at two places.

When you decide this all is complete nonsense than please ignore this


Fix possible overflow with very large files in libsvn_delta

* subversion/libsvn_delta/text_delta.c
  (struct tpush_baton, compute_window): source_offset changed
  from apr_size_t to svn_file_size.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Nov 2 03:32:52 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.