[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix svn_io_remove_dir pool usage

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-11-02 01:03:23 CET

kfogel@collab.net wrote:
> It looks good to me. I'm kind of surprised we weren't doing it
> before, actually.
> You might want to move the subpool allocation to right before the
> for-loop, and its destruction to right after the for-loop, so it's
> clear that its scope is just the loop.

Agreed. Functionally it looks correct. Stylistically you are now using
'subpool' as an iteration pool, so it would be better to do as Karl says and
then rename it to 'iterpool' and don't use it outside the loop. (After the
loop, use the plain 'pool' instead of 'subpool', just as you did before the
loop). I don't believe there is any good reason for using a sub-pool that is
not an iteration pool in that function.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 2 01:03:46 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.