[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix fsfs finalization memory usage

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2004-11-01 22:09:09 CET

kfogel@collab.net writes:

> No, you'd just have to have an
>
> if (! change)
> break;
>
> at the top of the loop. (I assumed this to be part of the standard
> transformation from 'while' to 'do-while', sorry for not being more
> explicit.)

I was replying to your comments about leaving it a while loop.

> Then do at least add a comment explaining why using iterpool in that
> inital call to read_change() is not an abuse of iterpool's meaning.
> That would help clarify why the general pattern here is not like our
> usual loop-pool pattern.

Will do.

Here's a bit from your first message i forgot to reply to:

> Oops, where's the apr_pool_destroy(iterpool) call?

It didn't show up in the diff because it was already there; i did
not add iterpool, only correct its usage.

I still want to wait until Greg reviews this before committing.

Thanks.

--
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 1 22:09:34 2004

This is an archived mail posted to the Subversion Dev mailing list.