[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix possible overflow with very large files in libsvn_delta

From: Norbert Unterberg <Norbert_at_Unterberg.de>
Date: 2004-11-01 19:50:23 CET

Hi,

(second try, since the first one did not seem to make it to the list)

This is my first contribution so please react friendly on my possible
ignorance to your contribution rules :-)

When building TortoiseSVN, I noticed some compiler warnings when building
some of the SVN libraries. I looked closer at them and found a possible
problem in libsvn_delta. There is some piece of code that stores stream
offsets in a apr_size_t variable. If I interpret the code correctly, this
might fail on systems that support very large files (64 bit file offsets
stored in a 32 bit integer). The fix was easy and I just replaced apr_size_t
with svn_file_size at two places.

When you decide this all is complete nonsense than please ignore this
posting!

Norbert

------
Fix possible overflow with very large files in libsvn_delta

* subversion/libsvn_delta/text_delta.c
  (struct tpush_baton, compute_window): source_offset changed
  from apr_size_t to svn_file_size.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Nov 1 19:51:06 2004

This is an archived mail posted to the Subversion Dev mailing list.