[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 2112] svn revert is wasting time on unmodified files

From: <kfogel_at_collab.net>
Date: 2004-11-01 17:03:15 CET

Philip Martin <philip@codematters.co.uk> writes:
> Erik Huelsmann <ehuels@gmail.com> writes:
> >> ------- Additional comments from philip@tigris.org Sun Oct 31 07:02:49 -0700 2004 -------
> >> Look at adm_ops.c:revert_admin_things:1263, the call to
> >> svn_wc_text_modified_p. The force_comparison flag is deliberately
> >> set TRUE which means that a full-text comparison is done, which is
> >> slower than just checking timestamps. I assume this is done so
> >> that reverts work even if the timestamps are "wrong".
> >
> > Wouldn't it be faster to just revert the file, instead of doing a full
> > byte-for-byte comparison first, if the initial checks are
> > inconclusive?
>
> It's probably not a good idea to modify working copy files if we don't
> have too. It breaks hard links for example.

And another reason: it causes people's editors to needlessly prompt
them asking "File on disk has changed, really edit the buffer?" (or
whatever), which is annoying :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 1 18:57:10 2004

This is an archived mail posted to the Subversion Dev mailing list.