[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: failure notice (I'm pissed now)

From: Stefan Reichör <stefan_at_xsteve.at>
Date: 2004-10-31 22:21:15 CET

kfogel@collab.net writes:

> "Erik Huelsmann" <e.huelsmann@gmx.net> writes:
> > Ok, now you really pissed me off:
> >
> > - your tigris account is *not* xsteve
> > - your e-mail address in COMMITTERS is *not* valid
> > - psvn.el *does* contain your name and e-mail address
> > - looking at psvn.el logs after my previous post: you have been committing
> > patches written by others stating only their names, not e-mail addresses,
> > while we normally *do* do that in this project
> >
> > *All* of the above is in violation with project procedure or ethics.
> >
> > One more thing -if that's at all possible- and I'll have to propose commit
> > access revocation.
>
> Oooh, ouch :-).

I second that.

I put psvn.el a long time ago in the subversion repository.
At the moment I don't have the time to follow the subversion mailing
lists. Nor do I read the commit mails of the other project members.

I know, that many people are happy users of my emacs mode.

I lost the access (password) to my web.de account. I asked Karl to
change it to a valid address on 25th May. He told me, he couldn't
change it. So it stayed the old (no longer usable web.de address).

Can someone update my account information?
 
> This might be a *bit* harsh, Erik, although I agree with the some of
> content of what you are saying. But not all. Note that:
>
> 1. Quite a few of our contributed scripts have the author's name and
> email addresses in them. We've been okay with that, because they
> really are developed in a different way than the rest of
> Subversion. (The "territoriality cost" is lower, while the
> "contactability" benefit is arguably higher.)
>
> 2. Yes, we want the tigris account name to be the same as the SVN
> committer name. But it would be reasonable to blame me, or
> whoever, for not having noticed the discrepancy, since we were
> the ones who set up the SVN commit account. (The requirement was
> not even documented until fairly recently, as I recall.)
>
> 3. We haven't been perfectly consistent about including the email
> addresses as well as the names of contributors whose patches we
> apply. If Stefan was simply using the logs as an example, he
> could have been guided either way. Sure, *most* contribution
> commits include an email address, but check out r10889, r10791,
> r10773, r10690, r10389, r10217, r9894... among many others.
>
> We simply cannot get mad at Stefan for failing to follow an
> undocumented guideline that was always inconsistently applied.
>
> The core of your complaint is about log formatting, and I agree Stefan
> should start formatting the log messages in the usual style (and fix
> the old ones). However, this hardly rises to the level of commit
> access revocation -- and the fact that his mail bounced doesn't
> amplify the offense, even if it did make your life a bit inconvenient.
>
> Stefan, could you please fix your email address in COMMITTERS, fix up
> this log message, and fix up previous log messages?
>
> Thanks,
> -Karl

Do I have the access rights to edit the COMMITTERS file?

> > --- Weitergeleitete Nachricht / Forwarded Message ---
> > Date: Sat, 30 Oct 2004 22:44:49 +0200 (MEST)
> > From: "Erik Huelsmann" <e.huelsmann@gmx.net>
> > To: dev@subversion.tigris.org
> > Subject: Re: svn commit: r11672 - trunk/contrib/client-side/psvn
> >
> > Stefan,
> >
> > On Sat, 30 Oct 2004 14:45:00 -0500, xsteve@tigris.org <xsteve@tigris.org>
> > wrote:
> > > Author: xsteve
> > > Date: Sat Oct 30 14:45:00 2004
> > > New Revision: 11672
> > >
> > > Modified:
> > > trunk/contrib/client-side/psvn/psvn.el
> > > Log:
> > > Some patches from Richard Lewis
> > >
> > > * trunk/contrib/client-side/psvn/psvn.el:
> > > - (svn-status-use-history) Report the error when we chose a
> > non-directory
> > > - (svn-status-mouse-find-file-or-examine-directory): New command, bound
> > > to mouse-2: just like svn-status-find-file-or-examine-directory
> > > - (svn-status-mark-deleted): New command ,bound to '* D' to mark files
> > > scheduled for deletion (similar to '* A' and '* M')
> > > - (svn-status-mark-deleted): New command W bound to '* *' to mark files
> > > modifed and files scheduled for addition and files scheduled for
> > > deletion
> > > - Moved "Mark" and "Unmark" to the "Mark/Unmark" submenu
> > > - (svn-status-bury-buffer) Bury the *svn-log* buffer
> > > - Modified a few docstrings
> >
> > I'm starting to have a problem with this. (I also have a problem keeping a
> > nice tone in this mail.)
> >
> > On numerous occasions you have been asked to commit with HACKING compliant
> > logs. C Mike told you to loose the dashes. Karl Fogel has told you to
> > correct some old commit logs. Looking back at the history of psvn.el there
> > are still an extreme number of non-compliant logs left. Correct this log.
> > All non-compliant ones in the past would be nice.
> >
> > I really think you should start committing with compliant logs *now*. It's
> > not really hard, you know: Othes have been doing it for years.
> >
> > bye,
> >
> > Erik.

Sorry Erik, I didn't receive that mail until now. Is it possible to
forward the xsteve@tigris.org mails to my valid email? That way I
would get such hints earlier.

Regarding the wrong formatting of the log messages:
* I use the hyphen formatting for my personal projects. So it is kind
  of a hardwired habit.
* I didn't use the hyphen in r11476, r11370, ...
* I just forgot about it in r11672 - sorry. I will fix it.

Please tell me, if the following log messages comply with your standards:

------------------------------------------------------------------------
r11672 | xsteve | 2004-10-30 21:45:00 +0200 (Sat, 30 Oct 2004) | 14 lines

Some patches from Richard Lewis <rpil+psvn.el@rtf.org.uk>

* trunk/contrib/client-side/psvn/psvn.el:
  (svn-status-use-history) Report the error when we chose a non-directory
  (svn-status-mouse-find-file-or-examine-directory): New command, bound
   to mouse-2: just like svn-status-find-file-or-examine-directory
  (svn-status-mark-deleted): New command ,bound to '* D' to mark files
   scheduled for deletion (similar to '* A' and '* M')
  (svn-status-mark-deleted): New command W bound to '* *' to mark files
   modifed and files scheduled for addition and files scheduled for
   deletion
  (svn-status-bury-buffer) Bury the *svn-log* buffer

  Moved "Mark" and "Unmark" to the "Mark/Unmark" submenu
  Modified a few docstrings
------------------------------------------------------------------------
r11476 | xsteve | 2004-10-18 21:35:38 +0200 (Mon, 18 Oct 2004) | 4 lines

The files are now highlighted, when the mouse is over them.

* trunk/contrib/client-side/psvn/psvn.el:
  (svn-add-face): Add a mouse-face to highlight the string, if the mouse is over it.
------------------------------------------------------------------------
r11370 | xsteve | 2004-10-13 22:41:00 +0200 (Wed, 13 Oct 2004) | 4 lines

Fixed another bug in the new fast commit functionality

* trunk/contrib/client-side/psvn/psvn.el:
  The last fix does not work very well. Added another fix to improve the situation.
------------------------------------------------------------------------
r11369 | xsteve | 2004-10-13 22:38:25 +0200 (Wed, 13 Oct 2004) | 6 lines

Fixed a bug in the new fast commit functionality

* trunk/contrib/client-side/psvn/psvn.el:
  (svn-status-parse-commit-output): Skip the leading directory,
  if the commit was sent for the . entry in the *svn-status* buffer

------------------------------------------------------------------------
r11368 | xsteve | 2004-10-13 22:15:54 +0200 (Wed, 13 Oct 2004) | 6 lines

Added a popup menu on mouse-3

* trunk/contrib/client-side/psvn/psvn.el:
  (svn-status-popup-menu): new function.
  (svn-status-face-set-temporary-during-popup): helper function for svn-status-popup-menu.

------------------------------------------------------------------------
r11245 | xsteve | 2004-10-05 21:05:05 +0200 (Tue, 05 Oct 2004) | 14 lines

Speedup for svn commit operation, because svn status is not run after a commit.

* trunk/contrib/client-side/psvn/psvn.el:
  (svn-status-line-info->set-propmark, svn-status-line-info->set-localrev,
  svn-status-line-info->set-lastchangerev): new functions to allow the
  modification of the svn-status-info data structure.
  (svn-status-update-with-command-list): New function to apply a list of changes
  to svn-status-info and the *svn-status* buffer.
  (svn-status-annotate-status-buffer-entry): Helper function to apply one
  change in svn-status-update-with-command-list.
  (svn-status-parse-commit-output): New function that is used to parse the
  output of svn commit. That function generates a list that is usable for
  svn-status-update-with-command-list.
  (svn-status-goto-file-name): Improved performance for that function.

Stefan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 1 08:54:43 2004

This is an archived mail posted to the Subversion Dev mailing list.