[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 2112] svn revert is wasting time on unmodified files

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-10-31 15:25:50 CET

Erik Huelsmann <ehuels@gmail.com> writes:

>> ------- Additional comments from philip@tigris.org Sun Oct 31 07:02:49 -0700 2004 -------
>> Look at adm_ops.c:revert_admin_things:1263, the call to
>> svn_wc_text_modified_p. The force_comparison flag is deliberately
>> set TRUE which means that a full-text comparison is done, which is
>> slower than just checking timestamps. I assume this is done so
>> that reverts work even if the timestamps are "wrong".
> Wouldn't it be faster to just revert the file, instead of doing a full
> byte-for-byte comparison first, if the initial checks are
> inconclusive?

It's probably not a good idea to modify working copy files if we don't
have too. It breaks hard links for example.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 31 15:26:13 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.