[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_path_canonicalize() broken in 1.1.x on cygwin (was: SVN 1.1.1: Cannot find .subversion folder (CYGWIN) on users@)

From: Roland Schwingel <Roland.Schwingel_at_onevision.com>
Date: 2004-10-28 09:56:13 CEST

Hi...

"Max Bowsher" <maxb@ukf.net> wrote on 27.10.2004 20:14:18:

> Ben Reser wrote:
> > On Wed, Oct 27, 2004 at 06:35:50PM +0100, Max Bowsher wrote:
> >> I assume CYGWIN is an APR define?
> >
> > No idea.
> >
> >> The platform standard predefined-by-compiler #define for detecting
cygwin
> >> is __CYGWIN__.
> >
> > Then we ought to use that?
>
> I think CYGWIN is an APR abstraction.
>
> Since we use apr to hide other platform oddities, I guess we should use
it
> here too.
>
> It's just a matter of checking up on the CYGWIN definition logic, before
we
> start to rely on it.
The -DCYGWIN came from the ./configure stage to the CPPFLAGS variables in
the
Makefile. So I used that because I thought it would be the intended
abstraction
for it. __CYGWIN__ (and __CYGWIN32__) are normally defined by gcc's spec
file
on cygwin. In my eyes __CYGWIN__ can be used identical to the CYGWIN
abstraction.

The __CYGWIN__ variant would have the slight benefit that it would also
work if
the abstracted CYGWIN define would fade away...

Roland

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 29 01:23:49 2004

This is an archived mail posted to the Subversion Dev mailing list.