[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11640 - in trunk: . subversion/libsvn_subr subversion/tests/libsvn_subr

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-10-28 11:37:23 CEST

Philip Martin wrote:

>philip@tigris.org writes:
>
>
>
>>Author: philip
>>Date: Wed Oct 27 17:31:58 2004
>>New Revision: 11640
>>
>>Added:
>> trunk/subversion/tests/libsvn_subr/compat-test.c
>>Modified:
>> trunk/build.conf
>> trunk/subversion/libsvn_subr/version.c
>>Log:
>>Fix svn_ver_compatible to correctly test release minor numbers.
>>Patch by Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>,
>>regression test tweaked by philip.
>>
>>
>
>I think the change in this patch is correct,
>
Indeed, I managed to reverse the comparison (again...)

> I'm not altogether sure
>about the rest of the function. The behavior is demonstrated
>explicitly by the regression test (a step forward even if the patch is
>wrong):
>
>
>>+ { {1, 1, 0, ""}, {1, 0, 0, ""}, FALSE },
>>
>>
>The above result for released versions...
>
>
>>+ { {1, 1, 0, "dev"}, {1, 0, 0, ""}, TRUE },
>>
>>
>...differs from the result for this development version.
>
>
Hm, yes. I think we should make the rule about devlopment versions
stricter: When comparing a -dev version with a released version, both
the major and minor version numbers must match, and the dev micro must
be larger thatn the released micro. That would change this (and the
following) result.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 28 11:42:12 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.