r11556 causes enormous fsfs memory use

Importing NetBSD src (822 MB, 89482 files, 10902 directories)
into an fsfs repository with svnserve 1.1.1, svnserve grows to
use 124 MB. The user who initially reported this to me saw it
bump into a 128 MB resource limit.

I tracked this down to r11556. Undo that from a 1.1.1 working
copy, and the memory usage decreases back to 1.1.0 levels which,
while bad[1], were at least acceptable.

Hopefully someone more familiar with this UTF-8 caching stuff (hi
lundblad and dionosos! :) will beat me to investigating further.
If not, i'll look into it tomorrow.

[1] Even with 1.1.0, there is something fishy going on with
    svnserve memory usage:

1.0.5 bdb:
32608 egillesp 25 0 28228 26M 2084 D 45.5 5.3 5:25 0 svnserve
32552 egillesp 15 0 5120 5064 1364 S 0.0 0.9 1:22 0 svn

1.1.0 bdb:
  384 egillesp 25 0 29348 26M 2272 D 31.3 5.3 5:38 0 svnserve
  328 egillesp 15 0 5972 5956 1588 S 0.0 1.1 1:22 0 svn

1.1.0 fsfs:
  871 egillesp 16 0 20632 19M 1072 R 10.3 3.9 7:38 0 svnserve
  815 egillesp 25 0 4852 4852 704 S 0.0 0.9 2:04 0 svn
  871 egillesp 17 0 66396 64M 1072 D 34.9 12.8 7:40 0 svnserve
  815 egillesp 25 0 4852 4852 704 S 0.0 0.9 2:04 0 svn

bdb has reasonable usage throughout its lifetime. fsfs does
through most of its life, but then spikes to 64MB at the end. Is
that the finalize-a-transaction-into-a-rev step? Does it have to
be so costly? With 1.1.1, we see the same pattern, except the
spike is from 23 MB to 124 MB:

21164 egillesp 25 0 24016 23M 1092 S 47.7 4.6 1:33 0 svnserve
21107 egillesp 25 0 12436 11M 1008 R 19.1 2.3 0:48 0 svn
[...]
21164 egillesp 16 0 55232 49M 1116 R 9.1 9.9 7:43 0 svnserve
21107 egillesp 25 0 32792 28M 704 S 0.0 5.6 2:00 0 svn
21164 egillesp 16 0 66820 61M 1064 R 12.7 12.2 7:43 0 svnserve
21107 egillesp 25 0 32792 28M 704 S 0.0 5.6 2:00 0 svn
21164 egillesp 15 0 98.0M 93M 1060 R 24.2 18.6 7:44 0 svnserve
21107 egillesp 25 0 32792 28M 704 S 0.0 5.6 2:00 0 svn
21164 egillesp 16 0 129M 124M 1128 D 22.3 24.8 7:46 0 svnserve
21107 egillesp 25 0 32768 28M 680 S 0.0 5.6 2:00 0 svn
21164 egillesp 15 0 1540 1528 1180 R 12.3 0.2 7:46 0 svnserve
21107 egillesp 15 0 30352 25M 900 D 0.0 5.1 2:00 0 svn

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org