[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Possibly wrong string comparisons in SVN

From: Roland Ruedenauer <Roland.Ruedenauer_at_yellow-computing.de>
Date: 2004-10-25 18:59:37 CEST

There seem to be some places in the SVN code where inadvertendly a
string prefix match is performed where a full match was desired.

1) libsvn_ra_local/split_url.c line 64

        if ((strncmp (hostname, "localhost", 9) != 0))

2) libsvn_repos/fs-wrap.c line 330 and 332

      /* Only svn:author and svn:date are fetchable. */
      if ((strncmp (propname, SVN_PROP_REVISION_AUTHOR,
                    strlen(SVN_PROP_REVISION_AUTHOR)) != 0)
          && (strncmp (propname, SVN_PROP_REVISION_DATE,
                       strlen(SVN_PROP_REVISION_DATE)) != 0))
        *value_p = NULL;

Other places?

--
Roland RŘdenauer
____________
Virus checked by inet.yellow-computing.de
Version: AVK 15.0.654, 25.10.2004
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 26 02:48:09 2004

This is an archived mail posted to the Subversion Dev mailing list.