[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]? svn status performance (win32)

From: Martin Hauner <hauner_at_web.de>
Date: 2004-10-24 21:13:09 CEST

Branko Čibej wrote:
> Martin Hauner wrote:
>
>> Hi,
>>
> Actually I suspect this patch gives most of the speedup. I get about 60%
> shorter times on a "svn st -v" of a SVN trunk working copy, compared to
> the 1.1.0 release. It also speeds up my ra_local tests by about 30%,
> which is quite a feat, given that I'm running them on a ramdisk. All in
> all, a good catch.
>
> (Of course, your log message is wrong, but I took care of that. :-)

That's ok with me. ;)

>> status.patch: There are two calls to io_check_path here which are used
>> to check for a 'special' file. As far as I see the only special case
>> is a link. As links are not used on Win32 i #ifndef'ed them.
>
>
> This one I don't like on philosophical grounds. If we do make
> special-file checks platform-specific -- something I don't like, either
> -- then the ifdef belongs inside svn_io_check_special_path, not in its
> callers.

I don't really like the #ifdef but it was the easiest for testing.
A better way would be a has_special_files function which returns false for
Win32 and true for anything else and then add a has_special_files to
io_check_special to save the apr_stat call.

> [..]
> My guess is that you meant to make the ..._p2 function private in
> libsvn_wc and have those functions that already do the check and then
> call svn_wc_text_modified_p call the private function instead.

Yes, much better this way. :) Would it create an acceptable patch?

>> All calls to svn_wc_text_modified_p do in some way the io_check_path
>> check. So maybe just removing the check here is an option?
>
>
> No, because svn_wc_text_modified_p is a public API, and you can't change
> its behaviour.

ah, I see, that makes sense.

-- 
Martin (http://subcommander.tigris.org, a subversion gui client)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 24 21:12:33 2004

This is an archived mail posted to the Subversion Dev mailing list.