[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]? svn status performance (win32)

From: Martin Hauner <hauner_at_web.de>
Date: 2004-10-23 16:17:20 CEST

Philip Martin wrote:
> Martin Hauner <hauner@web.de> writes:

>>* subversion/libsvn_wc/questions.c
>> (svn_wc_text_modified_p2): copied from svn_wc_text_modified_p and
>> removed the svn_io_check_path check.
>> (svn_wc_text_modified_p): Does the svn_io_check_path check and then
>> calls svn_wc_text_modified_p2.
>>
>>* subversion/libsvn_wc/status.c
>> (assemble_status): call svn_wc_text_modified_p2 instead of
>> svn_wc_text_modified_p.
>
>
> Our naming usually uses foo2 when foo2 is intended to replace foo.
> Since you don't appear to be replacing all the calls that's not really
> the case here, is it?

No.

That patch is just a base for discussion.
I only wanted to modify the status case without impact on the rest of subversion.
I looked through the callers of svn_wc_text_modified_p and as far as
i see all do the check "somewhere". I wasn't sure if it save to simply
remove the check from svn_wc_text_modified_p. So i simply crated a
wrapper.

-- 
Martin (http://subcommander.tigris.org, a subversion gui client)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 23 16:16:41 2004

This is an archived mail posted to the Subversion Dev mailing list.