[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] SSL layer for svnserve

From: Sigfred Håversen <bsdlist_at_mumak.com>
Date: 2004-10-19 16:40:36 CEST

On Tuesday 19 October 2004 14.46, Joe Orton wrote:
> On Tue, Oct 19, 2004 at 02:12:34PM +0200, Sigfred Håversen wrote:
> > Here is the corresponding from my patch :
> >
> > +/* Format an ASN1 time to a string.
> > + * Adapted from Neon library.
>
> Your words not mine. It looks like you've copied it then changed it.
> Or was the function name mere coincidence? Keep the copyright notices
> obey the license if you copied the code.
>
> joe

The function name was to give credit to the Neon library for a
trivial function used to fill out the cert_info. I did not try to hide
anything, did I?

Is there anything else in my patch that you are unhappy about?
You do hint that there are other things as well. The place to look
for discrepancies is in fill_server_cert_info(), as it in this code I fill out
cert_info so that it contains the same as the one produced from
indirectly from Neon. Hint, hint, look at the switch-statement.
You'll find similar tests in the Postfix TLS patch as well.

/Sigfred

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 19 16:40:55 2004

This is an archived mail posted to the Subversion Dev mailing list.