[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] "move" shouldn't take a revision argument

From: <kfogel_at_collab.net>
Date: 2004-10-12 20:34:15 CEST

Julian Foad <julianfoad@btopenworld.com> writes:
> --- subversion/include/svn_client.h (revision 11328)
> +++ subversion/include/svn_client.h (working copy)
> @@ -1072,9 +1072,6 @@
> *
> * - @a dst_path must also be a repository URL (existent or not).
> *
> - * - @a src_revision is used to choose the revision from which to copy
> - * the @a src_path.
> - *
> * - the authentication baton in @a ctx and @a ctx->log_msg_func/@a
> * ctx->log_msg_baton are used to commit the move.
> *
> @@ -1085,8 +1082,7 @@
> *
> * - @a dst_path must also be a working copy path (existent or not).
> *
> - * - @a src_revision, and @a ctx->log_msg_func/@a ctx->log_msg_baton are
> - * ignored.
> + * - @a ctx->log_msg_func and @a ctx->log_msg_baton are ignored.
> *
> * - This is a scheduling operation. No changes will happen to the
> * repository until a commit occurs. This scheduling can be removed
> @@ -1110,6 +1106,22 @@
> * ### Is this really true? What about @c svn_wc_notify_commit_replaced? ###
> */
> svn_error_t *
> +svn_client_move2 (svn_client_commit_info_t **commit_info,
> + const char *src_path,
> + const char *dst_path,
> + svn_boolean_t force,
> + svn_client_ctx_t *ctx,
> + apr_pool_t *pool);
> +

I think you need to put

   @since New in 1.2.

or something in svn_client_move2()'s doc string?

> +/**
> + * @deprecated Provided for backward compatibility with the 1.1.0 API.
> + *
> + * Similar to @c svn_client_move2, but an extra argument @a src_revision
> + * must be passed. This has no effect, but must be of kind
> + * @c svn_opt_revision_unspecified or @c svn_opt_revision_head,
> + * otherwise error @c SVN_ERR_UNSUPPORTED_FEATURE is returned.
> + */
> +svn_error_t *
> svn_client_move (svn_client_commit_info_t **commit_info,
> const char *src_path,
> const svn_opt_revision_t *src_revision,

Beautiful!

Everything else looks good to me. A quick tags-search confirms that
there are no other callers of svn_client_move() in the core code.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 12 22:23:44 2004

This is an archived mail posted to the Subversion Dev mailing list.