Re: "move" shouldn't take a revision argument

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
[...]
>> * @a src_revision has no useful effect but must be of kind
>> * @c svn_opt_revision_unspecified or @c svn_opt_revision_head,
>> * otherwise error @c SVN_ERR_UNSUPPORTED_FEATURE is returned.
>>
>>Does this all sound right?
>
> Yep, sounds sane to me.

I'll see about making a patch.

> (What does the revision param do in the code right now, though? Have
> you traced it through?)

I have traced it. It is not used at all; it is only checked to ensure that it is @c svn_opt_revision_unspecified or @c svn_opt_revision_head. Perhaps my suggested doc string is still not clear enough. I'll remove the word "useful" from the doc string and leave "has no effect but must be of kind ..."

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 12 14:36:39 2004