[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "move" shouldn't take a revision argument

From: Ben Reser <ben_at_reser.org>
Date: 2004-10-12 04:22:32 CEST

On Tue, Oct 12, 2004 at 12:47:31AM +0100, Julian Foad wrote:
> Peter Hercek pointed out recently that "svn move" can take a revision
> argument. I see also that svn_client_move() does. That argument is
> meaningless. A WC move always acts on the working revision, and a
> repository move on the repository head revision. So...
>
> "svn move" should stop accepting "-r".
>
> "svn_client_move" should be deprecated and superceded by "svn_client_move2"
> which will be the same but without the revision parameter. The doc string
> of "svn_client_move" says:
>
> * If @a src_path is a repository URL:
> [...]
> * - @a src_revision is used to choose the revision from which to copy
> * the @a src_path.
> [...]
> * If @a src_path is a working copy path
> [...]
> * - @a src_revision, and @a ctx->log_msg_func/@a ctx->log_msg_baton are
> * ignored.
>
> but that is wrong and should be changed to match the implementation, which
> is (for any type of src_path):
>
> * @a src_revision has no useful effect but must be of kind
> * @c svn_opt_revision_unspecified or @c svn_opt_revision_head,
> * otherwise error @c SVN_ERR_UNSUPPORTED_FEATURE is returned.
>
> Does this all sound right?

+1

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 12 04:22:51 2004

This is an archived mail posted to the Subversion Dev mailing list.