Re: [PATCH] Ability to specify groups in groups (second time)

Quoting Michael W Thelen (thelenm@cs.utah.edu):
> >This is about the access control file specified via the
> >AuthzSVNAccessFile directive in httpd.conf. The [groups] part does not
> >allow one to specify other groups so it gets rather cumbersome to deal
> >with lots of users who are in different groups. For example:
> >
> >[groups]
> >permstaff = a, b, c, d, e
> >consultants = f, m
> >everyone = @permstaff, @consultants
>
> Thanks for the patch. I've filed it as issue #2085:
> http://subversion.tigris.org/issues/show_bug.cgi?id=2085

Hi

Here's a new revision of this patch based on Erik Huelsmann
wish. Sorry for not following up on his post. I accidently deleted
it.

The detection simply adds the groups it encounters to a hash
'checked_groups'. If a group exist in the hash it doesn't
recurse. This version does not change callers which the
previous patch did.

Revised log message (suggestion):

* subversion/mod_authz_svn/mod_authz_svn.c
  (group_contains_user, group_contains_user_check): Split up into two
  functions. A hash for the circular dependency check is created in
  group_contains_user() and passed to group_contains_user_check(). The
  _check() function now does the actual check and recurses if it
  encounters a group.

-- 
 Martin
 http://www.wulffeld.org/
 http://www.allornone.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org