Re: svn blame miscategorizing a file as binary

Simon Large wrote:
> > I still feel like I'm not getting through here :-) Try this example.
>
> We're getting two separate cases mixed up here. Your example above has a
> Word file with binary type set, and a LaTex file with text type set. You
> correctly state that the LaTex file should be blameable and the Word
> file not. And that would also apply if the same file had changed from
> Word to LaTex at some stage, along with its mime type. The easy solution
> there is just to ignore all revisions whose mime-type is binary.

You split this into two cases but I think it's simpler than that.

Instead of ignoring binary revisions (i.e., having blame assign all
that content to the first revision commited with text MIME type),
when the revision you're viewing has text MIME type, we should just
proceed normally pretending that all revisions have text MIME type.

Then, if the original file really was binary, then none of its content
will be preserved in the blame (barring some extremely unlikely
coincidence) because there will be no common whole "lines" of text.

If it was really text, then the common lines will properly show through
and be blamed correctly.

Either way, everything should work out right!

-Archie

__________________________________________________________________________
Archie Cobbs * CTO, Awarix * http://www.awarix.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 11 23:41:03 2004