[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Unitialized variable on Win 95/98/Me machines...

From: John Szakmeister <john_at_szakmeister.net>
Date: 2004-10-10 18:57:42 CEST

I've been working with Khairul on the users@ list trying to pinpoint a
problem with the svnadmin client. It was returning an error string
saying that it "Can't convert modoule path to UTF-8." After further
investigation, it seems there is a bug in svn_cmdline_init(). Mainly,
when you have NLS stuff turned on under Windows, a block of code gets
executed to find the path to the locale data. Well, in Win98/Me, the
GetFileModuleNameW() function is not implemented and returns an error
without touching the argument. Hence, ucs2_path is passed uninitialized
to apr_conv_ucs2_to_utf8(), and happens to result in the above error on
Khairul's machine.

I've developed a patch to work around this problem without bringing in
Microsoft Layer for Unicode (MSLU) support, but unfortunately, I don't
have a Win 98 machine to test it on. I think the attached patch can at
least cause us to correctly retrieve the path and get it into UCS2
format. However I have a couple of lingering questions:
 1) Does the NLS stuff even work on Win 95/98/Me?
 2) If not, then do we still claim to support 98?

Right now, we claim not to support Win 95/98/Me because of the bdb
backend. Now that we have fsfs, can we theoretically run Subversion on a
Win 95/98/Me machine?

I'm looking for some guidance from some of the other Windows svn devs out
there. Also, if anyone can help test the attached patch and provide
feedback, I'd appreciate it.

For anyone interested in the users@ thread, you can find it here:
http://www.contactor.se/~dast/svnusers/archive-2004-10/0220.shtml

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Oct 10 18:57:53 2004

This is an archived mail posted to the Subversion Dev mailing list.