[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: slow status

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-10-10 18:04:05 CEST

On Fri, 2004-10-08 at 15:19, Peter N. Lundblad wrote:
> On Thu, 7 Oct 2004, Greg Hudson wrote:
>
> > Presumably we're locking the anchor recursively.
> >
> > I thought we had fixed this ages ago, but I guess not.
> >
> Maybe the attached patch will fix this problem?

Locking the anchor with depth 2 is a botch. If you look at
svn_client_switch(), you can see an example of locking the anchor
non-recursively and then locking the target.

I think doing that can also simplify the logic. If there is a target,
lock the anchor non-recursively and then lock the target (recursively or
not, as specified). If there is no target, lock the anchor recursively
or not as specified. That's fewer cases than your patch has.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 10 18:04:29 2004

This is an archived mail posted to the Subversion Dev mailing list.