[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: problem with r11262

From: Doug Currie <e_at_flavors.com>
Date: 2004-10-07 22:38:51 CEST

Simon Large wrote:
> "Ben Collins-Sussman" wrote
>> But this seems to have broken my win32 nightly tests.
>> It looks like our parsing of win32 drive letters no longer works:
>
> Can the nightly tests also include UNC paths so that issue 2011 (when it is
> fixed) doesn't slip through.

Issue 2011 describes a problem with working-copy paths.

UNC paths also don't work in repository URIs.

It would be nice if

file://host/path/to/repos

translated to UNC

\\host\path\to\repos

on Windows.

There may be some objection to putting a host name in the file spec; an
alternative is

file:////host/path/to/repos

but svn strips away one of the leading slashes.

Is it svn_path_canonicalize that is stripping away one of the leading
// in the UNC pathname? If so, perhaps svn_path_canonicalize could
be changed so that

  /* If this is an absolute path, then just copy over the initial
     separator character. */
  if (*src == '/')
    {
      *(dst++) = *(src++);
      absolute_path = TRUE;
    }

becomes

  /* If this is an absolute path, then just copy over the initial
     separator character. */
  if (*src == '/')
    {
      *(dst++) = *(src++);
      absolute_path = TRUE; /* not used ? */

      /* for Windows only!? a second slash means this is a UNC path */
      if (*src == '/')
        {
          *(dst++) = *(src++);
          UNC_path = TRUE; /* not used ? */
        }
    }

e

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 8 05:13:58 2004

This is an archived mail posted to the Subversion Dev mailing list.