[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_repos_trace_node_locations()

From: Archie Cobbs <archie_at_dellroad.org>
Date: 2004-10-01 18:11:02 CEST

Julian Foad wrote:
> >> Would it violate our API promises to add 'const' to the
> >> location_revisions parameter of this function in svn_repos.h:
> >>
> >> svn_error_t *
> >> svn_repos_trace_node_locations (svn_fs_t *fs,
> >> apr_hash_t **locations,
> >> const char *fs_path,
> >> svn_revnum_t peg_revision,
> >> apr_array_header_t *location_revisions,
> >> apr_pool_t *pool);
> >>
> >> ?
> >
> > I'm guessing 'yes', since we already have this issue:
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1952
> > which is purely a reminder to const-ify a different pointer come 2.0.
>
> May I suggest you add this to issue #1952, and broaden the summary of the issue to cover all such 'const' additions?

I don't see how adding "const" would break the API. That change
would simply acknowledge to new application code what is already
true in the library code, namely, that svn_repos_trace_node_locations()
does not modify *location_revisions. Maybe I don't understand the
"API promises".

-Archie

__________________________________________________________________________
Archie Cobbs * CTO, Awarix * http://www.awarix.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 1 18:15:34 2004

This is an archived mail posted to the Subversion Dev mailing list.