[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] SVNPathAuthz is broken

From: Tobias Ringström <tobias_at_ringstrom.mine.nu>
Date: 2004-09-30 01:20:31 CEST

The SVNPathAuthz directive which was introduced recently is broken in
the sense that you can only set it to off in the topmost scope in the
config file, i.e. is not possible to say "SVNPathAuthz Off" in a
Location block. The following patch fixes the problem and a similar
problem for SVNAutoversioning, but I don't have time to run the test
suite etc right now, so I'm posting the patch here instead. I'll commit
it tomorrow when I know that it passes all tests.

Note that there is at least one problem left, because ls is a lot slower
than before, even with SVNPathAuthz off.


Fix the inheritence of SVNPathAuthz and SVNAutoversioning by turning
them into tri-state values (default, on, off).

* subversion/mod_dav_svn/mod_dav_svn.c
  (dav_svn_flag): New tri-state enum.

  (dav_svn_dir_conf): Use dav_svn_flag for autoversioning and

  (dav_svn_create_dir_config): Zero is default for all values now.

  (dav_svn_autoversioning_cmd, dav_svn_pathauthz_cmd): Use
  dav_svn_flag values.

  (dav_svn_get_autoversioning_flag): It's only on if it's explicitly
  set to on.

  (dav_svn_get_pathauthz_flag): If's only off if it's explicitly set
  to off.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Sep 30 01:21:08 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.