Re: svn commit: r11155 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_ra_dav libsvn_ra_local libsvn_ra_svn libsvn_repos mod_dav_svn svnserve tests/clients/cmdline/getopt_tests_data

kfogel@collab.net wrote:
> "C. Michael Pilato" <cmpilato@collab.net> writes:
>
>>The XML parser doesn't allow us to return custom errors, so we have to
>>the "squirrel away an error in the baton and then bail with a generic
>>parse errorcode" trick.
>
>
> Yeah -- what's exceptional in this case is, we're *not* squirelling
> away an error in the baton, but we're still bailing with the generic
> parse errorcode. I'm not sure our code is completely prepared for
> that combination.

If I recall correctly (and it has been some time since I wrote that part
of the code, and nobody commented on it in the pre-commit reviews, so I
haven't dug into it very much recently) that is what is keeping us from
actually showing the user an error in this case. At the time I did dig
through some of this stuff, and it seemed to be doing the right thing
(for some value of "the right thing"), although I could be misremembering.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 28 19:13:36 2004