Re: svn commit: r11155 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_ra_dav libsvn_ra_local libsvn_ra_svn libsvn_repos mod_dav_svn svnserve tests/clients/cmdline/getopt_tests_data

Philip Martin wrote:
> Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
>
>>I'm leaning towards just making it an unsigned int and moving on
>>with life myself...
>
>
> We already have functions, e.g. svn_path_remove_components, where it
> doesn't make make sense to pass a -ve value (they don't document it
> either) so perhaps just say "-ve values are invalid".
>

Why only document it when we can force the issue by declaring the
argument unsigned? It seems awfully close to saying "we're never going
to modify this argument" instead of just making it const.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 28 18:58:34 2004