Re: svn commit: r11155 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_ra_dav libsvn_ra_local libsvn_ra_svn libsvn_repos mod_dav_svn svnserve tests/clients/cmdline/getopt_tests_data

Philip Martin wrote:

> You risk having values greater than INT_MAX converted into negative
> numbers (and the svn_repos_get_log3 documentation doesn't say what
> happens if limit is negative :)

True. Perhaps an unsigned int would be more appropriate? I can't think
of any reasonable behavior for a negative limit.

> Of course values greater than INT_MAX won't occur if you are starting
> with an int in the first place... which raises a question about
> ra_svn_log2: it's probably not valid to pass an int to
> svn_ra_svn_write_tuple with an "n" format, as that will attempt to
> retrieve 8 bytes from the varargs when only 4 bytes have been passed.
>

Good point. Will casting to an apr_uint64_t in the call to
svn_ra_svn_write_tuple be enough to avoid that, or do we actually have
to use a temporary variable?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 28 04:29:42 2004