Hi James,
I have few stylistic comments about your patch log.
1) Always send a log and patch together, even when one of them is same
as earlier. This makes reviewerer's job much easier, when she/he
can see the actual log message and patch in the same message.
2) Please separate your filename lines with a blank line, and after
that indent your entries for that file. This will make them much
more readable.
3) Provide higher level message first, and after that detailed file
level entries. This way reviewer will get big picture first and
after that detailed information how this big picture is
implemented/changed.
There should be some text and guides of that in HACKING, and you could
copycat old log messages. This way we could keep Subversion's
beautiful log messages consistent and people keep going and asking
which tool has been used to formulate them. =)
BR, Jani
P.S. I reformatted your log entry, so that you don't have to do it
again, and it is more clear this way what I meant.
LOG MESSAGE:
This patch fixes the dependency problems with javahl-java and
javahl-javah by making all .class files dependent on all .java files.
This patch also solves the bug behind issue 2039:
http://subversion.tigris.org/issues/show_bug.cgi?id=2039
* build/generator/gen-base.py
(gen_base.TargetJavaClasses.add_dependencies): Add class file to
dependency list instead of source file.
* gen_make.py
(gen_make.Generator.write): Switched TargetJavaClasses rules to
depend on the object files instead of the source files. These
object files are generated in a single call to 'javac'. This
change prevents unnecessary regeneration of .class files.
(gen_make.Generator.write): Switched TargetJavaHeaders rules to
depend on the header files instead of the source files. These
header files are generated in a single call to 'javah'. This
change prevents unnecessary regeneration of .h files.
(gen_make.Generator.write): Added code to keep track of
dependencies for new TargetJavaHeaders and TargetJavaClasses rules
--
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 19 08:15:10 2004