[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Autobuild dependencies before install

From: David James <staple_at_gmail.com>
Date: 2004-09-18 18:45:45 CEST

> We deliberately don't do that. (Or at least, to the extent we don't do
> that, it's deliberate. It's come to my attention that we're a little
> bit inconsistent, because the bindings maintainers aren't necessarily on
> the same wavelengths as the team as a whole.)
>
> In my little world, and I'm not totally alone, either you're asking a
> makefile to build something or you're asking a makefile to do something,
> and it can be very frustrating when you ask for the latter and get the
> former.
>
> For instance, right now our "swig-py" target is broken such that it
> rebuilds the Python bindings even if nothing has changed. Because
> install-swig-py is one of the inconsistent targets in our Makefile (it
> depends on swig-py), if I run:
>
> make swig-py CFLAGS=-g # or some other option to the build
> make install-swig-py
>
> I will, frustratingly, get a rebuild of the Python bindings, ignoring
> the flag I so carefully passed when building them. This isn't the end
> of the world, but neither is having to tell the Makefile to build stuff
> and install it in two steps like you're supposed to.

I can understand your frustration. The core problem you refer to here
is that many of our targets are broken such that they rebuild their
outputs even if nothing has changed. Fortunately, my patch also fixes
this issue. (If there's anything I missed, let me know and I'll fix
it!)

What this means: If you type 'make install', make will only recompile
your targets if the sources have changed. If not, it won't. In any
case, it will install subversion.

Greg, does this address your concerns?

> This isn't the end of the world, but neither is having to tell the Makefile
> to build stuff and install it in two steps like you're supposed to.
In some cases, it's much more than two steps. For example, the process
of testing JavaHL is currently:

1. ./configure [with some options]
2. make
3. make javahl
4. make install-javahl
5. make check-javahl

With my patch (and Holger Thon's patch at
<http://www.contactor.se/~dast/svn/archive-2004-09/0408.shtml>), it's
2 steps:
1. ./configure [with some options]
2. make check-javahl

Try installing the following make targets with and without my patch.
It's simple as pie to install these targets with my patch, but I can't
figure out how to install them without my patch. Without my patch,
these make targets emit mysterious errors.
- make install-lib (just the libraries, no binaries needed)
- make install-bin (just the binaries!)
- make install-bdb-lib (just the BDB library and its dependencies)

Cheers,

David

P.S. The bug you referred to in the SWIG build process is a
pre-existing issue, and I plan to fix it in a separate patch.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 18 18:46:28 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.