Re: PATCH: $Header$ keyword support (now with proper log message)

On Wed, Sep 15, 2004 at 10:01:56AM -0400, Alexander L. Belikoff wrote:
> I'm sorry for not chiming in earlier (was a bit busy), but could anyone
> explain to me the public nature of this particular structure? I am not sure I
> see where this structure is being passed between the client and the server.
> Because if it is not, then there should hardly be any problem (except for the
> case where headers are inconsistent with the libraries, which is a major
> screw-up anyway).

One other thing nobody seemed to mention was that svn_subst_keywords_t
is not allocated by the library. It is allocated by the client prior to
passing it to svn_subst_build_keywords. It would have been better to
make it an opaque data structure and allocate it ourselves and not
reveal it's structure the clients directly. Unfortunately, we didn't do
that.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org