Re: [PATCH] Command prefixes for the test suite (for valgrind et al)

Greg Hudson <ghudson@MIT.EDU> writes:

> I figured it might be nice if, every so often, one of us runs the test
> suite through valgrind. Lacking any convenient way to do so, I hacked
> up the following patch to allow command prefixes in the test suite.

If you are using shared libraries I suspect this won't do what you
want. The libtool "executable" is a shell script that invokes the
real executable, so running

   valgrind subversion/clients/cmdline/svn

runs valgrind on the transient shell used to invoke the real
executable. When I run the tests using valgrind I edit the
subversion/clients/cmdline/svn script and change the exec line to
invoke valgrind.

I suppose it might work if you disabled the shared libraries, if
that causes libtool to avoid the intermediate script.

> Then, by specifying a prefix of "valgrind -q --tool=memcheck", I can
> make each of the test suite commands run through valgrind. This is
> rather slow (maybe 2-3 times slower than the regular test suite run),
> but it works.

2-3 doesn't sound right, valgrind is much slower than that on my
machine. Hence, I suspect you are only running valgrind on the shell.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org