[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10868 - trunk/build/ac-macros

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-09-10 19:14:20 CEST

On Thu, 2004-09-09 at 20:49, breser@tigris.org wrote:
> + if [ test -f "$where" ]; then
> + if [ test ! -f "$SWIG" ] || [ test ! -x "$SWIG" ]; then

The square brackets around the test commands are harmless in this
context (they act as m4 quote characters in this context), but are
confusing because you've written what at first glance appears to be
invalid shell code.

Also, the second statement is weird, firstly because it uses two test
processes instead of -o, and secondly because the second test seems to
subsume the first one (that is, just 'test ! -x "$SWIG"' would seem to
do the job).

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 10 19:16:46 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.